Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert accidental direct commits to master #11765

Closed
wants to merge 2 commits into from

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 21, 2024

Related Issues

Adresses an issue where two commits were accidentally pushed directly to the master branch of the Lotus repository. The commits in question are:

These commits introduced a significant number of changes directly into the master branch without undergoing PR review process.

Proposed Changes

I propose to revert these two commits, and then these commits can be reintroduce through the standard PR review proces.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverting way too much

@magik6k
Copy link
Contributor

magik6k commented Mar 21, 2024

Closing in favor of #11767

@magik6k magik6k closed this Mar 21, 2024
@rjan90 rjan90 deleted the revert-accidental-commits branch March 25, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants